aws-samples / sagemaker-studio-image-build-cli

CLI for building Docker images in SageMaker Studio using AWS CodeBuild.
https://pypi.org/project/sagemaker-studio-image-build/
MIT No Attribution
56 stars 25 forks source link

sm-docker build does not work when delaing with private Pypi repos #15

Open RamdevWudaliTR opened 3 years ago

RamdevWudaliTR commented 3 years ago

If a Docker file installs libraries from a private PyPi repo (a repo. within a VPC), the docker build fails from the codebuild project. The reason being, the code build project is not configured to run within a VPC.

  1. Enhance sm-docker to accept additional codebuild parameters so that it can accept the VpcConfig (or)
  2. Enhance sm-docker to accept a config file where all the command line options can be passed in, allowing easy of passing in more options (including authentication/authorization details to the codebuild project)
  3. Allow for "custom" naming of codebuild projects (passing in the name for the codebuild project as n argument or in the config file)
ikopas commented 3 years ago

I picked up the work on implementing a feature to enable the optional VPC configs to be passed as arguments.