search

aws-samples / sagemaker-studio-image-build-cli

CLI for building Docker images in SageMaker Studio using AWS CodeBuild.
https://pypi.org/project/sagemaker-studio-image-build/
MIT No Attribution
56 stars 25 forks source link

feat: added option to specify additional codebuild env variables #20

Open marcelgwerder opened 3 years ago

marcelgwerder commented 3 years ago

Description of changes:

This change adds the ability to specify additional environment variables for the CodeBuild job. My use case requires me to activate Docker BuildKit in order to use secrets and this is an easy way to do it. However, this feature can also be useful for other purposes.

I tried to make this change as mergeable as possible, please let me know if there is anything you need me to change. It would be great if this could be merged and released within reasonable time.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

marcelgwerder commented 3 years ago

@jaipreet-s

orangewise commented 2 years ago

Any chance this will be merged?

orangewise commented 1 year ago

@jaipreet-s?