aws-samples / sagemaker-studio-lifecycle-config-examples

MIT No Attribution
78 stars 51 forks source link

Auto-shutdown server-only extension needs wget as written #3

Closed athewsey closed 2 years ago

athewsey commented 2 years ago

As I understand, the install-autoshutdown-server-extension sample includes some guidance on how to install via S3 cp for efficient Internet-free install setup, but by default uses wget from GitHub.

Unfortunately, the sudo yum install -y wget line is commented out - so trying the script out with no modifications causes an error.

I suggest we either:

  1. Un-comment the installer so the sample runs correctly from internet out-of-the-box, or
  2. Make VPC-only the default, comment out wget by default and focus on setup instructions for the S3 command

Since users might be interested in the no-UI installation regardless of VPC isolation, and option (2) would increase the barrier to set up the sample, I'd probably lean towards option (1)?