search

aws-samples / sagemaker-studio-lifecycle-config-examples

MIT No Attribution
78 stars 51 forks source link

[Bug] install-lsp-features fetches unsupported version of bash-language-server #34

Closed athewsey closed 1 year ago

athewsey commented 1 year ago

NPM package bash-language-server provides IDE-like autocomplete/hinting for Jupyter in the install-lsp-features sample LCC (used here).

However, this week they released major version 5.0.0 which drops support for NodeJS v14... And currently, SageMaker Studio JupyterServer seems to use NodeJS v14 so the sample now fails to run.

Suggest pinning this install as e.g. bash-language-server@"<5.0.0" until Studio JupyterServer environment gets updated?

durgasury commented 1 year ago

PR #35 merged