search

aws-samples / sagemaker-studio-sparkmagic-lib

MIT No Attribution
7 stars 8 forks source link

Change the manifest file to include data file directory in the pip package #3

Closed edwardps closed 3 years ago

edwardps commented 3 years ago

Change the manifest file to include data file directory in the pip package

The sagemaker-studio-sparkmagic-lib pip package[3] missed the sample_config.json[1]. This file is loaded as base configuration in the connect logic[2], which would fail.

[1] https://github.com/aws-samples/sagemaker-studio-sparkmagic-lib/blob/main/sagemaker_studio_sparkmagic_lib/data/sample_config.json [2] https://github.com/aws-samples/sagemaker-studio-sparkmagic-lib/blob/main/sagemaker_studio_sparkmagic_lib/sparkmagic.py#L112 [3] https://pypi.org/project/sagemaker-studio-sparkmagic-lib/

Testing Done Manually build the pip package and following are files included in the new tar file. The data folder is correctly included.

tar -tvf dist/sagemaker_studio_sparkmagic_lib-0.1.tar.gz

       0 May 28 16:18 sagemaker_studio_sparkmagic_lib-0.1/
     927 May 28 16:05 sagemaker_studio_sparkmagic_lib-0.1/LICENSE
     926 May 28 16:05 sagemaker_studio_sparkmagic_lib-0.1/LICENSE.txt
     184 May 28 16:18 sagemaker_studio_sparkmagic_lib-0.1/MANIFEST.in
      99 May 28 16:05 sagemaker_studio_sparkmagic_lib-0.1/NOTICE
    5718 May 28 16:18 sagemaker_studio_sparkmagic_lib-0.1/PKG-INFO
    4083 May 28 16:05 sagemaker_studio_sparkmagic_lib-0.1/README.md
       0 May 28 16:18 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib/
       0 May 28 16:05 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib/__init__.py
    1697 May 28 16:05 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib/cli.py
       0 May 28 16:18 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib/data/
    1828 May 28 16:05 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib/data/
    9490 May 28 16:05 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib/emr.py
    2977 May 28 16:05 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib/kerberos.py
    5706 May 28 16:05 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib/sparkmagic.py
       0 May 28 16:18 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib.egg-info/
    5718 May 28 16:18 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib.egg-info/PKG-INFO
     657 May 28 16:18 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib.egg-info/SOURCES.txt
       1 May 28 16:18 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib.egg-info/
      76 May 28 16:18 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib.egg-info/
      40 May 28 16:18 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib.egg-info/
      32 May 28 16:18 sagemaker_studio_sparkmagic_lib-0.1/sagemaker_studio_sparkmagic_lib.egg-info/
      38 May 28 16:18 sagemaker_studio_sparkmagic_lib-0.1/setup.cfg
    1230 May 28 16:05 sagemaker_studio_sparkmagic_lib-0.1/setup.py

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.