search

aws-samples / serverless-java-frameworks-samples

MIT No Attribution
150 stars 38 forks source link

Add Quarkus SnapStart example #17

Closed ravsrin closed 1 year ago

ravsrin commented 1 year ago

Issue #, if available: https://github.com/aws-samples/serverless-java-frameworks-samples/issues/13

Description of changes: Added SnapStart example for Quarkus Java framework

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

dmahapatro commented 1 year ago

@ravsrin I have preliminary comments. You ran the GraalVM version, did you see any changes in benchmarks for Quarkus? If yes, can you update that too. My review is not complete yet. Will spend some more time on it this week.

ravsrin commented 1 year ago

@dmahapatro Sure, I can update the GraalVM benchmarks in case the latest GraalVM version 22.3.1 has any improvements. I also updated to the latest version of Quarkus 2.16.1-Final and can update the JVM without SnapStart benchmarks in case they improved too. With SnapStart, I included class preloading from the Quarkus AWS Lambda SnapStart Configuration Guide which may help the JVM without SnapStart benchmarks as well. I'll include these updates in the overall PR comments.