search

aws-samples / serverless-java-frameworks-samples

MIT No Attribution
150 stars 38 forks source link

Update & Polish Spring Cloud Function sample #6

Closed maciejwalkowiak closed 2 years ago

maciejwalkowiak commented 2 years ago

This PR bundles couple of changes that I believe will improve Spring Cloud Function sample:

I left comments explaining each change below.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

dmahapatro commented 2 years ago

@maciejwalkowiak Thank for the PR. I will review it as soon as I can. With this change, were you able to run the load test against them. If yes, can you please also update the benchmark numbers in the README file?

maciejwalkowiak commented 2 years ago

I didn't run the load test, but will do and update the readme 👍

@dmahapatro thought about it again - what is the estimated cost that these load tests generate?

dmahapatro commented 2 years ago

@maciejwalkowiak I never needed to calculate. It should be relatively negligible because DDB is PAY_PER_REQUEST and the max I have run the load test was for 10 minutes. You can skip the load test, let me run that myself and report my results here.

dmahapatro commented 2 years ago

@maciejwalkowiak Looks like your fork is one commit behind from main repo. Can you pull latest?

maciejwalkowiak commented 2 years ago

@dmahapatro done!

dmahapatro commented 2 years ago

@maciejwalkowiak Thank you for the PR.

maciejwalkowiak commented 2 years ago

Awesome, thanks!