aws-samples / serverless-patterns

Serverless patterns. Learn more at the website: https://serverlessland.com/patterns.
https://serverlessland.com
Other
1.48k stars 863 forks source link

appsync-data-with-images #1002

Closed mtliendo closed 1 year ago

julianwood commented 1 year ago

Looks like folder is generic. Suggest renaming to appsync-cognito-dynamodb-cdk or something. README doesn't include deployment instructions.

mtliendo commented 1 year ago

Thanks Julian! Carved out time tomorrow morning to get all these addressed, much appreciated!

mtliendo commented 1 year ago

Looks like folder is generic. Suggest renaming to appsync-cognito-dynamodb-cdk or something.

Just double checking that you're referring to the cdk folder. Can definitely change, but looking at other repos, using cdk seems to be the standard.

julianwood commented 1 year ago

Looks like folder is generic. Suggest renaming to appsync-cognito-dynamodb-cdk or something. README doesn't include deployment instructions.

I think the pattern name should be appsync-cognito-dynamodb-cdk rather than appsync-data-with-images. This isn't the cdk folder but the whole pattern folder. The pattern folder should be the same as in the example-pattern.json

julianwood commented 1 year ago

Hi @mtliendo Any update on this?

jbesw commented 1 year ago

Closing due to inactivity.