search

aws-samples / serverless-patterns

Serverless patterns. Learn more at the website: https://serverlessland.com/patterns.
https://serverlessland.com
Other
1.48k stars 863 forks source link

Initial commit for serverless pattern #1291

Closed diwakarkvs closed 11 months ago

diwakarkvs commented 1 year ago

Issue #, if available: New serverless pattern - apigw-authorizer-sqs

Description of changes: This queue levelling pattern can be used when customers want to use APi Gateway RestAPI to send messages to Amazon SQS and have APIGW authorize the request.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mavi888 commented 1 year ago

@diwakarkvs please fill the README.md file correctly and make sure that there are no extra files commited in ths PR.

After that is fixed i will continue my review.

Cheers

diwakarkvs commented 1 year ago

@mavi888 , I updated the README.md and deleted README copy.md and READEME.md-OLD files. I had to add a few pictures to provide context to README content. So i checked in 3 images to /images folder.

mavi888 commented 1 year ago

This pattern is not yet ready for merging. Please fix the comments and then is the folder cloudformation templates needed? if not please remove.

Also please remove any extra files that is not needed for the project to work or is not a required one listed in here https://github.com/aws-samples/serverless-patterns/tree/main/_pattern-model. Such as contributing, code of conduct, or licence.

is source.bat required?

This project has an enourmous amount of files that im not sure they are required for this pattern to work. please clean

saikotag commented 1 year ago

Hi Mavi, Updated the code and README.md file based on your comments and inputs. Please review it when you get a chance. Thanks

mavi888 commented 12 months ago

Still some comments to fix in this PR.

Also why the authorizer function cannot be created as IaC in the project? The solution will be more elegant if that is added to it.

saikotag commented 12 months ago

Since APIGW is using custom Lambda authorizer, where users can implement their own token validation logic, I feel that it is best to have users implement their own lambda logic that best suits them. Although, the lambda function can be created as IaC they still have to customize and write their own code, instead as 'Requirements' we have a step Create Lambda authorizer from blueprint

mavi888 commented 11 months ago

This pattern was merged and published in this link: https://serverlessland.com/patterns/cdk-apigw-authorizer-sqs

Thanks a lot for contributing!