search

aws-samples / serverless-patterns

Serverless patterns. Learn more at the website: https://serverlessland.com/patterns.
https://serverlessland.com
Other
1.48k stars 863 forks source link

[Follow up PR] New pattern submission: Lambda Elastic IP without NAT Gateway #1645

Closed MohamadSoufan closed 8 months ago

MohamadSoufan commented 8 months ago

Issue #, if available: #1642

Description of changes:

Removed the function name from the filter Added documentation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This is a follow up PR to this PR

MohamadSoufan commented 8 months ago

Hello @mavi888 this is a follow-up PR to this PR I want to draw your attention to the that this pattern page hasn't yet been populated checkout here it is just a blank white page... Did we make a mistake in the documentation?

jbesw commented 8 months ago

For #1644, the pattern is now live at https://serverlessland.com/patterns/lambda-elastic-ip-no-nat-gateway-cdk.

MohamadSoufan commented 8 months ago

For #1644, the pattern is now live at https://serverlessland.com/patterns/lambda-elastic-ip-no-nat-gateway-cdk.

Thank you very much, James,

We are publicly advertising this new pattern on LinkedIn

github-actions[bot] commented 8 months ago

@MohamadSoufan looks like you are missing the example-pattern.json file in your pattern.

You can find the example-pattern template here.

The file is used on ServerlessLand and is required. Once the file is added we can review the pattern.

MohamadSoufan commented 8 months ago

@MohamadSoufan looks like you are missing the example-pattern.json file in your pattern.

You can find the example-pattern template here.

The file is used on ServerlessLand and is required. Once the file is added we can review the pattern.

There is an example pattern.json file in this pattern

This is a follow up PR on a previous one

MohamadSoufan commented 8 months ago

@mavi888 @jbesw @ can we merge this PR?