aws-samples / serverless-patterns

Serverless patterns. Learn more at the website: https://serverlessland.com/patterns.
https://serverlessland.com
Other
1.48k stars 863 forks source link

New serverless pattern - AWS Secrets Manager to CloudWatch Events to SNS (Terraform) #1722

Closed MakendranG closed 6 months ago

MakendranG commented 7 months ago

Issue #, if available: https://github.com/aws-samples/serverless-patterns/issues/1723

Description of changes:

This pattern contains a terraform template to detect and notify on Amazon Secrets Manager Secret Key Creation, Updation and Deletion using Amazon CloudWatch event and Amazon SNS.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

MakendranG commented 7 months ago

The example-pattern file have all the parameters. Still failing the checks. Kindly update which parameter is getting failed.

MakendranG commented 7 months ago

Hello @mavi888

Thanks for the update. As per the request, I have updated the pattern file. Automated system have picked the pattern and validated. Now it is waiting for approval. Kindly do the needful.

mavi888 commented 7 months ago

I just tested this pattern and it doesnt work. When looking at the rule created there is no target defined for it.

MakendranG commented 7 months ago

I just tested this pattern and it doesnt work. When looking at the rule created there is no target defined for it.

Have modified the terraform file with the target.

MakendranG commented 7 months ago

Hello @mavi888

Thanks for the update. As per the request, I have updated the terraform file. Automated system have picked the pattern and validated. Now it is waiting for approval. Kindly do the needful.

mavi888 commented 7 months ago

The pattern doesnt work. Please test it before submiting it again

mavi888 commented 6 months ago

This pattern still doesnt work. I will close it and please open it when you are sure you test it out, granted all the permissions needed and everything is polished.