search

aws-samples / serverless-patterns

Serverless patterns. Learn more at the website: https://serverlessland.com/patterns.
https://serverlessland.com
Other
1.48k stars 863 forks source link

Serverless pattern eventbridge schedule remove one time schedules cdk python #1992

Closed manikandanks2000 closed 4 months ago

manikandanks2000 commented 5 months ago

Issue #, if available:

Description of changes: Remove completed Amazon EventBridge Schedules and sent notification using Amazon SNS

This pattern will create an Amazon EventBridge Scheduler and will run every five minutes and will use AWS Lambda to identify expired and completed Amazon Evenbridge Scheduler tasks that are expired 7 days or more and will send an SNS notification once the activity is completed. The pattern is deployed using the AWS Cloud Development Kit (AWS CDK) for Python.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

github-actions[bot] commented 5 months ago

@undefined looks like you are missing the example-pattern.json file in your pattern.

You can find the example-pattern template here.

The file is used on ServerlessLand and is required. Once the file is added we can review the pattern.

manikandanks2000 commented 5 months ago

pattern file and project files updated and included in the merge request . thanks blog referenced is providing steps on how to remove one time schedule using aws console and did not provide a CDK code for reference.

github-actions[bot] commented 4 months ago

@undefined your 'example-pattern.json' is missing some key fields, please review below and address any errors you have

  1. authors[0].linkedin: authors[0].linkedin. Please remove the URL in this property, only include the ID to your LinkedIn profile.

_If you need any help, take a look at the example-pattern file._

Make the changes, and push your changes back to this pull request. When all automated checks are successful, the Serverless DA team will process your pull request.

github-actions[bot] commented 4 months ago

Valid pattern file found.

Reviewer you can view the pattern file here

manikandanks2000 commented 4 months ago

agreed. updated the folder names as advised. architecture reference diagram available in img folder as below /img/onetimeschedule-architecturediagram.png let me know if this should be placed in the parent folder or otherwise. thanks again

github-actions[bot] commented 4 months ago

Valid pattern file found.

Reviewer you can view the pattern file here

github-actions[bot] commented 4 months ago

Valid pattern file found.

Reviewer you can view the pattern file here

github-actions[bot] commented 4 months ago

Valid pattern file found.

Reviewer you can view the pattern file here

pputhran commented 4 months ago

@manikandanks2000 I had to fix a couple of small changes in the example-pattern.json file. Please have a look and see if this applies to your other submissions as well. Rest looks good and this PR will be merged in soon. Thanks for your submission.

manikandanks2000 commented 4 months ago

thanks for your help and the changes made.

manikandanks2000 commented 3 months ago

@pputhran i see the project merged successfully. but the github project folder name need to be corrected as below. Let me know whether a new merge request is required to make this change.

https://serverlessland.com/patterns/eventbridge-schedule-remove-one-time-schedules-cdk-python

Incorrect path used : https://github.com/aws-samples/serverless-patterns/tree/main/eventbridge-schedule-remove-onetime-schedule-to-sns-cdk-python

Correct path to be used : https://github.com/aws-samples/serverless-patterns/tree/main/eventbridge-schedule-remove-one-time-schedules-cdk-python

pputhran commented 3 months ago

Please open a new PR with the fix.