search

aws-samples / serverless-patterns

Serverless patterns. Learn more at the website: https://serverlessland.com/patterns.
https://serverlessland.com
Other
1.58k stars 924 forks source link

[Suggestion] Advice on DDB Stream read throttling on existing pattern #2406

Closed lucacucchetti closed 1 month ago

lucacucchetti commented 2 months ago

Hello, I was reading this pattern (github here) and since it depicts 7 lambdas subscribed to the same DDB stream I think it should warn people that (source):

You can subscribe to more than two Lambda functions. If you subscribe more than two Lambda functions to one DynamoDB stream, read throttling might occur.

So people don't mistake it for a production ready pattern.

Happy to submit a very simple CR highlighting this, just looking for confirmation this is wanted.

julianwood commented 2 months ago

Hi, thanks for the suggestion. If you can submit a PR with the wording changes, that would be great.

lucacucchetti commented 2 months ago

Hello, thanks! Will probably do so in the next few days.

In order to do it I assume I'll need to restore the original example-pattern.json, and modify it (and the README)?

I don't quite understand how to contribute otherwise or why these files were removed.

lucacucchetti commented 2 months ago

Hello again, I see the PR is merged.

Is there something I should do in order for the actual pattern page to be updated?

julianwood commented 1 month ago

Hi, sorry this fell through the cracks to update the main page. Done. I've also restored the missing examples files which should make it easier to create new ones