search

aws-samples / serverless-patterns

Serverless patterns. Learn more at the website: https://serverlessland.com/patterns.
https://serverlessland.com
Other
1.48k stars 863 forks source link

cdk-appsync-sns #996

Closed mtliendo closed 1 year ago

mtliendo commented 1 year ago

Update to showcase L2 construct and AppSync JS functions in a pipeline

github-actions[bot] commented 1 year ago

@mtliendo looks like you are missing the example-pattern.json file in your pattern.

You can find the example-pattern template here.

The file is used on ServerlessLand and is required. Once the file is added we can review the pattern.

mavi888 commented 1 year ago

It would be great if the testing part of the README included how to verify that this worked. Now it says that it publishes to SNS, but how i know ? How i can see the message?

mtliendo commented 1 year ago

Updated with example-pattern.json. @mavi888 The request from AppSync to SNS returns the SNS messageId to verify that SNS received the message. Does that work or is there another form you're looking for?

mtliendo commented 1 year ago

I'm sure it's something small, but I could use another pair of eyes on why the example-pattern.json isn't successfully validating 🙏🏽

mavi888 commented 1 year ago

I will merge this pattern, but I think you can add more value by explaining a bit more in the readme what is going on.

mavi888 commented 1 year ago

Thanks for submitting your pattern. Now this pattern is public in Serverless land

https://serverlessland.com/patterns/cdk-appsync-sns

You can share your pattern using this link :)