search

aws-samples / serverless-rust-demo

Sample serverless application written in Rust
MIT No Attribution
267 stars 21 forks source link

Add basic CI #3

Closed brainstorm closed 3 years ago

brainstorm commented 3 years ago

Description of changes: Add continuous integration via GHA to catch issues like #2 early.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

brainstorm commented 3 years ago

@nmoutschen I guess you noticed already, but I'll be explicit: I'd suggest not merging this until issue #2 is fixed, because it also fails the same way on CI anyway, see: https://github.com/brainstorm/serverless-rust-demo/runs/3762807603#step:9:91

nmoutschen commented 3 years ago

I've added gcc-aarch64-linux-gnu, which fixes the CI.

For issues in #2 and more, I need to continue experimenting on setting up and/or using the right toolchain for cross--compilation.

bnusunny commented 3 years ago

For musl builds, check out https://musl.cc/. Works pretty well.

brainstorm commented 3 years ago

For musl builds, check out https://musl.cc/. Works pretty well.

Check https://github.com/awslabs/aws-lambda-rust-runtime/discussions/306... MUSL introduces unnecessary static bloat when provided.al2 already supports native GLIBC binaries, plus you can relatively easily change the allocator to optimize performance further.