aws-samples / service-screener-v2

A tool for customers to evaluate their AWS service configurations based on AWS and community best practices and receive recommendations on potential improvements.
Apache License 2.0
167 stars 46 forks source link

RDS Scanner Unsupported Operand type #50

Closed sheshankgujjari closed 7 months ago

sheshankgujjari commented 7 months ago

Describe the bug File "/home/cloudshell-user/service-screener-v2/services/Evaluator.py", line 28, in run getattr(self, method)() File "/home/cloudshell-user/service-screener-v2/services/rds/drivers/RdsCommon.py", line 401, in _checkOldSnapshots diff = now - oldest_copy_date TypeError: unsupported operand type(s) for -: 'datetime.date' and 'datetime.datetime'

To Reproduce Steps to reproduce the behavior:

  1. Clone Repo
  2. Setup Alias
  3. Run command: screener --regions us-east-1 --services rds

Full commands used to reproduce this bug e.g: screener --regions ALL --services rds,iam,ec2 screener --regions us-east-1 --services rds

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

AWS CloudShell (please complete the following information):

kuettai commented 7 months ago

Taking a look

kuettai commented 7 months ago

Successfully simulated and resolved in #51