search

aws-samples / sigv4a-signing-examples

Code examples in various frameworks for creating requests using the AWS SigV4a protocol
MIT No Attribution
56 stars 23 forks source link

feat: add go examples #15

Closed ChocolateAceCream closed 8 months ago

ChocolateAceCream commented 9 months ago

Issue #13 , if available:

Description of changes: Add go examples

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

lovaarte commented 9 months ago

Hi @ChocolateAceCream, thanks for PR. Your code looks to be going SigV4 instead of SigV4A. SigV4 can only handle regional signature/endpoint, however SigV4A is multi-regional. Happy to merge if you would submit SigV4A samples equivalent to how it's done in other languages in this repo.

ChocolateAceCream commented 9 months ago

Hi @ChocolateAceCream, thanks for PR. Your code looks to be going SigV4 instead of SigV4A. SigV4 can only handle regional signature/endpoint, however SigV4A is multi-regional. Happy to merge if you would submit SigV4A samples equivalent to how it's done in other languages in this repo.

Hi @lovaarte, according to https://github.com/aws/aws-sdk-go-v2/issues/1935, the SigV4A is not public yet, so I guess it's not possible to do an example using SigV4A right now. However, it's hard to even find a SigV4 go example online so it would be nice to have at least some example here I guess?

lovaarte commented 8 months ago

Agree, there is also a greater need for SigV4 examples. We are actually thinking to create a separate repo for SigV4 examples (cc @jhart0). However, at this point I think this repo should only have SigV4A examples and not mix those two as that surely will start being confusing for folks.

ChocolateAceCream commented 1 month ago

Hi Artem,

Thanks for your reply.

From: Artem Lovan @.> Sent: Saturday, February 17, 2024 2:34 AM To: aws-samples/sigv4a-signing-examples @.> Cc: Di Sheng @.>; Mention @.> Subject: Re: [aws-samples/sigv4a-signing-examples] feat: add go examples (PR #15)

Hi @ChocolateAceCreamhttps://github.com/ChocolateAceCream, thanks for PR. Your code looks to be going SigV4 instead of SigV4A. SigV4 can only handle regional signature/endpoint, however SigV4A is multi-regional. Happy to merge if you would submit SigV4A samples equivalent to how it's done in other languages in this repo.

— Reply to this email directly, view it on GitHubhttps://github.com/aws-samples/sigv4a-signing-examples/pull/15#issuecomment-1949079183, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC7UOUNTB4AWO2IPRW6O6YTYT6RCLAVCNFSM6AAAAABCXC4J5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBZGA3TSMJYGM. You are receiving this because you were mentioned.