search

aws-samples / startup-kit-templates

CloudFormation templates to accelerate getting started on AWS.
Apache License 2.0
815 stars 400 forks source link

Simplified Stack Creation #19

Closed rnzsgh closed 6 years ago

rnzsgh commented 6 years ago

This PR adds wrapper stacks for one-click installation of the various components. The CFN templates are being hosted in the startup account in the awslabs-startup-kit-templates-deploy-v1 bucket. The deploy.sh script in bin was added to assist in updating the templates.

The foundation for fully automated regional testing was added in bin/test.py. The bastion host AMIs were also updated to the latest versions, the EB application stacks were updated to the latest versions and support for us-west-3 was added.

The base/core CFN templates were moved to the "templates" directory, so we will need to update blog posts that directly reference these files will need to be updated in tandem.

Manually tested the Fargate stacks and did manual testing of the EB, VPC and bastion stacks in various regions and numerous automated tests in all of the supported regions.

john commented 6 years ago

Can we push the test script in a subsequent PR, just for change control?

john commented 6 years ago

This is a pre-existing thing not from this PR, but in bastion.cfn.yml, line 305, the description says it alarms on >10 in 5 minutes, but the threshold on line 311 is set to 15 (imo the threshold should be lower, maybe 5)

rnzsgh commented 6 years ago

@jpignata I hear you regarding the size and scope. Sometimes, you take on too much under a tight deadline and you just have to get things out the door. In the future, I will try to keep the PRs smaller and more focused. I agree about the temporary buckets and keys, and I will follow-up with another PR to rectify this situation. As @john mentioned, he has a follow-up with the README.

@john - Let's chat offline to coordinate your readme changes. I need to get this up because there are customers who want to get going with. I agree with JP about breaking up the large tables into smaller ones, so LUD.