search

aws-scripting-guy / cform-VSCode

CloudFormation extension for Visual Studio Code
86 stars 36 forks source link

YAML syntax error when using AWS intrinsic functions #12

Open callumslab opened 6 years ago

callumslab commented 6 years ago

Hi there,

Many thanks for adding YAML support to your extension.

I'm hitting the following issue in VS Code when using intrinsic functions:

capture

I assume that this issue is being reported by the "YAML Support by Red Hat" plugin that your plugin now depends on?

I'm not sure how this issue should be resolved i.e. within your plugin, within the configuration of the Red Hat plugin or by changing the syntax of my YAML but obviously I'm conforming to the syntax used by AWS in their examples

Any assistance would be greatly appreciated!

Many thanks

aws-scripting-guy commented 6 years ago

Thanks for reporting this. You are right syntax is valid per YAML specs - seems to be a bug within Red Hat YAML server, issue open here https://github.com/redhat-developer/yaml-language-server/issues/77)

cmmeyer commented 5 years ago

Heya from one of the maintainers of cfn-python-lint!

We stumbled upon your extension because one of our users was trying to use our extensions together and got hit by the issue described here.

Does it makes sense for you to integrate with us for validation instead of a basic YAML linter? I would love to see a consistent tool chain for linting and code completion!

aws-scripting-guy commented 5 years ago

Heya from one of the maintainers of cfn-python-lint!

We stumbled upon your extension because one of our users was trying to use our extensions together and got hit by the issue described here.

Does it makes sense for you to integrate with us for validation instead of a basic YAML linter? I would love to see a consistent tool chain for linting and code completion!

Hi and thank you for reaching out! I haven't been active in the project for a while so completely missed out your comment.

I've checked the rules in cfn-lint and I really like the idea. I would need to spent time with it, as I'm not getting consistent results - both CLI and VS Code extension.

I think that cfn-lint can be complementary to YAML language server, which I see as necessary - as it provides additional capabilities (for example format document functionality)

philn5d-ar commented 4 years ago

try updating the list on the readme to what's here: https://github.com/redhat-developer/yaml-language-server/issues/77#issuecomment-511768680