aws-solutions-library-samples / osml-model-runner

MIT No Attribution
7 stars 1 forks source link

test: cleaning up structure and comments in test_request_queue.py #113

Closed drduhe closed 2 weeks ago

drduhe commented 3 weeks ago

Issue #, if available: n/a

Notes

This PR enhances the existing unit tests for the RequestQueue class by adding descriptive comments, improving readability, and standardizing the assertion methods. The changes ensure better documentation and clarity on the purpose of each test case, facilitating easier maintenance and understanding for future contributors.

Changes

  1. Added Docstrings:

    • Each test method now includes a descriptive docstring explaining the purpose and expected behavior of the test. This helps to clarify the test intent and aids in faster understanding for reviewers and future developers.
  2. Standardized Assertions:

    • Replaced assert statements with self.assert methods for consistency across the test suite. This approach provides clearer test output and integrates better with the unittest framework.
  3. Code Cleanup:

    • Removed unnecessary comments and redundant code.
    • Enhanced readability by reformatting code blocks and adding appropriate line breaks.
  4. Maintained Existing Test Coverage:

    • Verified that all original test cases remain intact, with improved clarity but no functional changes to the tests.

Checklist

Before you submit a pull request, please make sure you have the following:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.