Open thesuavehog opened 7 months ago
Note: I just noticed that AWS has added the AwsAccountName
property into the Finding JSON definition. I am not sure under what conditions this field is added (or not) since it is marked as Optional.
If it is essentially always included, then the changes in the PR for this issue could get updated to default to using that value and skip the aws_api_client.get_connection('organizations').list_accounts()
call ... but even in my local fork I have left in the extra call as the fallback when the AwsAccountName
is not in the Finding data.
Thank you for this request. we will add it to our backlog and consider it in a future release.
Is your feature request related to a problem? Please describe.
In a multi-account AWS Organization, when remediating a number of accounts, the notifications that SHARR sends out after remediation is attempted could be much more useful. Information like the Account Alias to help know immediately which account was affected, a link to the Finding so you don't have to copy and paste as much, and the Note from the remediation are all useful things that will save administrators time.
Describe the feature you'd like
Additional properties int he SHARR notifications such as:
SUCCESS | QUEUED | RESOLVED | PENDING | FAILED
) so that better filtering on the SNS Topic subscriptions can be applied to reduce the noise from running a large number of remediations