aws-solutions / aws-control-tower-customizations

The Customizations for AWS Control Tower solution combines AWS Control Tower and other highly-available, trusted AWS services to help customers more quickly set up a secure, multi-account AWS environment using AWS best practices.
https://docs.aws.amazon.com/controltower/latest/userguide/cfct-overview.html
Apache License 2.0
355 stars 205 forks source link

v2.3.0 should be deployed to official S3 repository #110

Closed mdaehnert closed 2 years ago

mdaehnert commented 2 years ago

Issue: Currently the v2.3.0 states on its release notes, that Customers should now download the Customizations for AWS Control Tower CloudFormation Template from GitHub instead of S3

As CfCT lab leverages the official S3 template, others will fail to use the right one.

Request: Push v2.3.0 template file to https://s3.amazonaws.com/solutions-reference/customizations-for-aws-control-tower/latest/custom-control-tower-initiation.template

balltrev commented 2 years ago

Hey @mdaehnert, per the release notes, GitHub is now the official source of distribution for CfCT as of v2.3.0.

We will work with the owners of CfCT lab to update documentation to reflect this.

jrosco commented 2 years ago

Sorry to highjack this issue, but what about the deploy zip files in the s3 solutions bucket?

For example the following S3 file does not exist for v2.3.0

s3://solutions-reference/customizations-for-aws-control-tower/v2.3.0/custom-control-tower-state-machine.zip

but v2.2.0 does exist

s3://solutions-reference/customizations-for-aws-control-tower/v2.2.0/custom-control-tower-state-machine.zip

Will v2.3.0 be added to the solutions-reference bucket?

balltrev commented 2 years ago

@jrosco the bucket location was updated as part of the v2.3.0 release, which was automatically included in the new source for the CfCT template

For non-self deployed/hosted CfCT deployments, the files are all sourced from this new bucket, as an example for the state machine zip:

s3://control-tower-cfct-assets-prod/customizations-for-aws-control-tower/v2.3.0/custom-control-tower-state-machine.zip