aws-solutions / aws-control-tower-customizations

The Customizations for AWS Control Tower solution combines AWS Control Tower and other highly-available, trusted AWS services to help customers more quickly set up a secure, multi-account AWS environment using AWS best practices.
https://docs.aws.amazon.com/controltower/latest/userguide/cfct-overview.html
Apache License 2.0
355 stars 205 forks source link

Removing a CFN template parameter doesn't trigger the change #112

Open akefirad opened 2 years ago

akefirad commented 2 years ago

Describe the bug In a CFN StackSet, when I remove a parameter which has a default value (different from what I set previously), the stack-set doesn't get updated. (Consequently stack instances won't be updated either.)

To Reproduce In my case, I tried to deploy CDK Toolkit stack using the official template (generated via the CLI):

  1. Add the template, and set the required parameters. The one I tried was the qualifier, set a value abcdef123 other than the default one (which is hnb659fds).
  2. Deploy the resources. All resources get created. All good.
  3. Now remove the qualifier parameter, which essentially should change its value to the default one (which is different with what is deployed).
  4. Push the changes. Nothing changes.

Please complete the following information about the solution:

Additional context To be clear I'm not sure if this is a bug or feature. And I'm not even sure if this is the behavior of CfCT or CFN or something else.

Thanks.

stumins commented 2 years ago

Hey @akefirad

I was able to reproduce this bug in our test environments. I've created a backlog item to improve the logic regarding input parameters.

Thanks for bringing this to our attention!