search

aws-solutions / aws-control-tower-customizations

The Customizations for AWS Control Tower solution combines AWS Control Tower and other highly-available, trusted AWS services to help customers more quickly set up a secure, multi-account AWS environment using AWS best practices.
https://docs.aws.amazon.com/controltower/latest/userguide/cfct-overview.html
Apache License 2.0
355 stars 205 forks source link

Removing the SCP from the manifest file does not detach the SCP from the OUs. #130

Open gabrielbac opened 1 year ago

gabrielbac commented 1 year ago

Describe the bug Removing the SCP from the manifest file does not detach the SCP from the OUs

To Reproduce

  1. Add an SCP to the manifest
  2. Run the pipeline
  3. See the SCP attached to the OU
  4. Remove the SCP from the manifest
  5. SCP is still attached.

Expected behavior SCP should have been detached.

Please complete the following information about the solution:

Region: [e.g. us-east-1]

I know this is similar to https://github.com/aws-solutions/aws-control-tower-customizations/issues/24 Partially resolved for stacksets in v2.5.0 but still needs to be resolved for SCPs

snebhu3 commented 1 year ago

@gabrielbac Thank you for reaching out. I have created a backlog to address this issue and discuss it with the team.

nd-at-globetel commented 1 year ago

@snebhu3 hi, any update regarding this issue?

snebhu3 commented 1 year ago

@nd-at-globetel unfortunately, we do not have an update at this time.

Cihl28 commented 7 months ago

I believe SCPs supports tagging. Please correct me if i'm wrong. They could be treated the exact same way as stacksets in this regard, i.e.:

jmino commented 5 months ago

Any update as to when this will be addressed?