aws-solutions / aws-control-tower-customizations

The Customizations for AWS Control Tower solution combines AWS Control Tower and other highly-available, trusted AWS services to help customers more quickly set up a secure, multi-account AWS environment using AWS best practices.
https://docs.aws.amazon.com/controltower/latest/userguide/cfct-overview.html
Apache License 2.0
360 stars 205 forks source link

Not able to add stackset outputs after initial deployment #132

Open hansarh opened 1 year ago

hansarh commented 1 year ago

Describe the bug After I have deployed a stack_set and defined some export_outputs I am not able append additional outputs after the initial deployment. f.ex if I have defined a stack_set like this:

  - name: beta-sharing-public-subnets
    description: Sharing public subnets in networking hub account
    resource_file: network/templates/public-subnets-sharing.yaml
    parameter_file: network/parameters-prod/beta/public-subnets-sharing-parameters-beta.json
    deploy_method: stack_set
    export_outputs:
      - name: /public-subnet-eu-west-1a
        value: $[output_PublicSubnetIDAZA]
      - name: /public-subnet-eu-west-1b
        value: $[output_PublicSubnetIDAZB]
    deployment_targets:
      accounts:
        -  # networking-hub
    regions:
      - eu-west-1

Adding an output after this is deployed does not result in an output being available for other stack_set definitions. I might need to output a third subnet after some time like this:

  - name: beta-sharing-public-subnets
    description: Sharing public subnets in networking hub account
    resource_file: network/templates/public-subnets-sharing.yaml
    parameter_file: network/parameters-prod/beta/public-subnets-sharing-parameters-beta.json
    deploy_method: stack_set
    export_outputs:
      - name: /public-subnet-eu-west-1a
        value: $[output_PublicSubnetIDAZA]
      - name: /public-subnet-eu-west-1b
        value: $[output_PublicSubnetIDAZB]
      - name: /public-subnet-eu-west-1b
         value: $[output_PublicSubnetIDAZC]
    deployment_targets:
      accounts:
        -  # networking-hub
    regions:
      - eu-west-1

To Reproduce Try deploying a stack_set and append a new output after the initial deployment

Expected behavior I expect adding an output to a stack_set will actually add an output.

Please complete the following information about the solution:

To get the version of the solution, you can look at the description of the created CloudFormation stack. For example, "(SO0089) - customizations-for-aws-control-tower Solution. Version: v1.0.0". You can also find the version from releases

Screenshots If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information).

Additional context Add any other context about the problem here.

snebhu3 commented 1 year ago

@hansarh thank you for reporting the issue. I have created a backlog to address this with the team.