search

aws-solutions / aws-control-tower-customizations

The Customizations for AWS Control Tower solution combines AWS Control Tower and other highly-available, trusted AWS services to help customers more quickly set up a secure, multi-account AWS environment using AWS best practices.
https://docs.aws.amazon.com/controltower/latest/userguide/cfct-overview.html
Apache License 2.0
360 stars 205 forks source link

Implement detection of oversize SCP's before the build and deployment steps. #133

Open Skripd opened 1 year ago

Skripd commented 1 year ago

Is your feature request related to a problem? Please describe. The customizations pipeline takes a long time to deploy in our organization. We have many SCP's. If an SCP exceeds 5120 bytes only then, late within the deployment, do we get notified of this problem.

Describe the feature you'd like My team came up with two ideas to mitigate this.

The first one is an automatic minimization of the SCP json files. This reduces SCP size. Deploying a SCP using the web console has this behavior.

Second can we be notified of SCP's that will fail the deployment due to it being larger than 5120 bytes, before the build and deploy steps. For example, an extra pipeline step which does a minimization/sanity check for size. This check could auto complete if no issues were found but require manual approval if a problem related to size is found. Therefore, blocking the deployment.

Additional context No context.

snebhu3 commented 1 year ago

@Skripd Thank you for the feature request. I have created an internal backlog to track this request.