aws-solutions / aws-control-tower-customizations

The Customizations for AWS Control Tower solution combines AWS Control Tower and other highly-available, trusted AWS services to help customers more quickly set up a secure, multi-account AWS environment using AWS best practices.
https://docs.aws.amazon.com/controltower/latest/userguide/cfct-overview.html
Apache License 2.0
355 stars 205 forks source link

Incorrect parameter_value parsing when comma is present #135

Open lapkritinis opened 1 year ago

lapkritinis commented 1 year ago

Describe the bug When deploying CFT if parameter is specified like this:

      - parameter_key: RoleType
        parameter_value: 'Standard (read only, custom policy)'

Parameter value gets modified to 'Standard (read only,custom policy)' (space gets removed)

To Reproduce Try launch template with such block:

Parameters:
  RoleType:
    Type: String
    AllowedValues:
      - Standard (read only, custom policy)
      - Standard-Managed (read only, AWS managed policy)

Expected behavior It should pick specified value

Please complete the following information about the solution:

balltrev commented 1 year ago

Thanks for bringing this to our attention @lapkritinis. This is actually a side effect it seems of the way we look for lists for parameter_value, I'll create a backlog with the team to discuss this.