search

aws-solutions / aws-control-tower-customizations

The Customizations for AWS Control Tower solution combines AWS Control Tower and other highly-available, trusted AWS services to help customers more quickly set up a secure, multi-account AWS environment using AWS best practices.
https://docs.aws.amazon.com/controltower/latest/userguide/cfct-overview.html
Apache License 2.0
354 stars 205 forks source link

pin PyYAML to 5.3.1 in source setup.py #184

Closed awseric closed 1 month ago

awseric commented 5 months ago

This fixes #183 by pinning PyYAML to version 5.3.1 in setup.py. I understand contributions are not being accepted currently, so I will use my fork until this gets merged, but wanted to get the core team's attention to the bug and it's fix.

Contributing to Customizations for AWS Control Tower (CfCT).

Thank you for your interest in contributing to Customizations for AWS Control Tower (CfCT).

At this time, we are not accepting contributions. If contributions are accepted in the future, Customizations for AWS Control Tower (CfCT) is released under the Apache license and any code submitted will be released under that license.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

snebhu3 commented 4 months ago

@awseric thank you for bringing this up. I will create a backlog to look into this.

wiltangg commented 1 month ago

Hi @awseric , thank you again for bringing this to our attention. Latest patch v.2.7.1 (release notes) included changes to pin the PyYAML in setup.py to 5.3.1.

I am going to resolve this issue, please reopen if there are follow up questions.