aws-solutions / aws-control-tower-customizations

The Customizations for AWS Control Tower solution combines AWS Control Tower and other highly-available, trusted AWS services to help customers more quickly set up a secure, multi-account AWS environment using AWS best practices.
https://docs.aws.amazon.com/controltower/latest/userguide/cfct-overview.html
Apache License 2.0
354 stars 205 forks source link

Bug: Unit test directory ./source/tests missing or purposely omitted? #196

Open tcmnal opened 3 weeks ago

tcmnal commented 3 weeks ago

I don't know if this issue qualifies strictly as a bug, but it is unexpected behaviour for the solution nonetheless.

Describe the bug I was previously working with v2.5.3. I recently synced my fork with the latest v2.7.1. The latest version seems to be missing the unit tests. Now running './deployment/run-unit-tests.sh' as part of my build, as suggested in README.md, is purposeless since no unit tests are found and ran.

Output: ... 445 | ============================= test session starts ============================== 446 | platform linux -- Python 3.11.9, pytest-6.2.4, py-1.11.0, pluggy-0.13.1 -- /codebuild/output/src14648982/src/testing-venv/bin/python3 447 | cachedir: .pytest_cache 448 | rootdir: /codebuild/output/src14648982/src, configfile: pytest.ini 449 | plugins: mock-3.5.1 450 | collecting ... collected 0 items 451 |   452 | ============================ no tests ran in 0.02s =============================

To Reproduce Clone v2.7.1 of repo. Follow instructions in ./README.md to run unit tests:

chmod +x ./deployment/run-unit-tests.sh
./deployment/run-unit-tests.sh

Expected behavior I expected unit tests to be located somewhere within the directory and ran.

Please complete the following information about the solution:

Additional context If unit tests are available but not published to this public repository, I would ask for that to be reconsidered, since they are useful for validating the solution.