search

aws-solutions / aws-control-tower-customizations

The Customizations for AWS Control Tower solution combines AWS Control Tower and other highly-available, trusted AWS services to help customers more quickly set up a secure, multi-account AWS environment using AWS best practices.
https://docs.aws.amazon.com/controltower/latest/userguide/cfct-overview.html
Apache License 2.0
356 stars 205 forks source link

Stack Set Deployment Option for Region Concurrency #60

Closed hitty5 closed 3 years ago

hitty5 commented 3 years ago

I'm using v2.0.0 mainly for rolling out manged AWS Config rules to almost all account in all regions. So in sum more than 200 stack instances are created. The stack set is created with following deployment options:

See https://github.com/awslabs/aws-control-tower-customizations/blob/677d12e16ecee9ae85c7fa056ded96aac5441525/source/aws/services/cloudformation.py#L28

So in case of so much instances with the above concurrent option it takes very long to apply the change to all accounts. Therefore it would be create to make the region concurrency configurable in manifest.yaml, e.g.

resources:
  - name: pcs-config-rules
    deploy_method: stack_set
    deploy_options:
       - region_concurrency = parallel

Based on https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/stacksets-concepts.html sequential deployment is the default selection

groverlalit commented 3 years ago

Thanks for raising this issue. This is already on our backlog and we plan to ship the fix in the next release.

groverlalit commented 3 years ago

This change was released in v2.1.0.