search

aws-solutions / aws-control-tower-customizations

The Customizations for AWS Control Tower solution combines AWS Control Tower and other highly-available, trusted AWS services to help customers more quickly set up a secure, multi-account AWS environment using AWS best practices.
https://docs.aws.amazon.com/controltower/latest/userguide/cfct-overview.html
Apache License 2.0
356 stars 205 forks source link

Resources that start with S3 are incorrectly being parsed as empty buckets #65

Closed milbrya closed 2 years ago

milbrya commented 3 years ago

https://github.com/awslabs/aws-control-tower-customizations/blob/8076f8feffeb0025431739df762b017a42db6470/source/manifest/manifest_parser.py#L364

I believe this should be 's3://'. I had created a resource that was named S3BPA and the code assumed it was a bucket (which didn't exist).

groverlalit commented 3 years ago

Thanks for bringing this our attention. We have added this our backlog.

aijunpeng commented 2 years ago

This issue has been fixed.