search

aws-solutions / aws-control-tower-customizations

The Customizations for AWS Control Tower solution combines AWS Control Tower and other highly-available, trusted AWS services to help customers more quickly set up a secure, multi-account AWS environment using AWS best practices.
https://docs.aws.amazon.com/controltower/latest/userguide/cfct-overview.html
Apache License 2.0
356 stars 205 forks source link

Added CodeStar Conections Functionality (Git) #85

Closed Micah-Quinland1 closed 2 years ago

Micah-Quinland1 commented 2 years ago

Issue #21: Add support for GitHub as Source provider #21 https://github.com/aws-solutions/aws-control-tower-customizations/issues/21

Description of changes: The below changes add more source provider options for the CFCT solution including - 'GitHub', 'GitHubEnterpriseServer', and 'Bitbucket' via CodeStarConnections. Branching logic has been modified but does not alter existing functionality if original Amazon S3 or AWS CodeCommit are selected. In this way the Code Pipeline source stage can pull from "GitConnection" i.e. the Git Repo. DetectChanges defaults ‘true’ but I have added for transparency. OutputArtifactFormat set to "CODEBUILD_CLONE_REF" is required. The default “CODE_ZIP” will prevent the code from pulling from the source.The user can now enter their Git Repository Name and Branch (with example formatting). This code also conditionally adds permissions for the CustomControlTowerCodePipelineRole and CustomControlTowerCodeBuildRole roles to use CodeStar Connections (only via IsGit check)

The CodeStarConnection will need to be finalized and the source stage reinitiated "retry" before the Code Pipeline will complete.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

balltrev commented 2 years ago

Hey @Micah-Quinland1, we're not currently accepting pull requests, but we've captured this as a feature request. Thanks!

DMEvanCT commented 1 year ago

Are you kidding me... Then make it happen! Fortune 500 companies don't like to use codecommit. Please get this done. This has been an issue in your backlog since 2021. It's now 2023.