aws-solutions / aws-control-tower-customizations

The Customizations for AWS Control Tower solution combines AWS Control Tower and other highly-available, trusted AWS services to help customers more quickly set up a secure, multi-account AWS environment using AWS best practices.
https://docs.aws.amazon.com/controltower/latest/userguide/cfct-overview.html
Apache License 2.0
355 stars 205 forks source link

Stack Self Drifts #98

Open felipeamarante opened 2 years ago

felipeamarante commented 2 years ago

Describe the bug The template has a Lambda Backed Custom Resource (CustomControlTowerDeploymentLambda) that modifies the attribute of the S3 Bucket (CustomControlTowerPipelineS3Bucket) created by the same stack. Thus, causing a configuration drift and potential alerts and bigger issues. Is there any way to avoid that? Perhaps avoid custom resources that configure stack managed resources? Thx

To Reproduce Launch the Stack, check drift.

Expected behavior Expected behaviour is to have no configuration drifts after stack creation. This could cause other issues if we had any mechanisms to revert drifts automatically.

Please complete the following information about the solution:

Screenshots If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information).

image

Additional context Add any other context about the problem here.

balltrev commented 2 years ago

Hey @felipeamarante, thanks for bringing this to our attention, I've opened a backlog with the team to tackle this issue.