search

aws-solutions / aws-data-lake-solution

A deployable reference implementation intended to address pain points around conceptualizing data lake architectures that automatically configures the core AWS services necessary to easily tag, search, share, and govern specific subsets of data across a business or with other external businesses.
https://aws.amazon.com/solutions/implementations/data-lake-solution/
Apache License 2.0
401 stars 160 forks source link

Okta federation instructions forgets to update lambda variables #36

Open jgc234 opened 5 years ago

jgc234 commented 5 years ago

The instructions for federation via Okta (Appendix B in deployment guide) updates app-variables.js variable FEDERATED_LOGIN, but does not update the lambda environment variable FEDERATED_LOGIN, which causes the wrong group source (cognito instead of custom:groups) to be used in access-validator, which causes all kinds of UI group related weirdness.

A quick fix could be to modify the cloudformation data-lake-deploy.template to pass through FederatedLogin: true to the DataLakeServicesStack only, and re-run a change-set.

knihit commented 4 years ago

Thank you for bringing the issue to our attention. We will put that item in our backlog and plan to fix it in an upcoming release.