switched from `sed` to `perl` for cross-platform compatibility

aws-solutions / aws-waf-security-automations

This solution automatically deploys a single web access control list (web ACL) with a set of AWS WAF rules designed to filter common web-based attacks.

https://aws.amazon.com/solutions/aws-waf-security-automations

Apache License 2.0

845 stars 361 forks source link

switched from `sed` to `perl` for cross-platform compatibility #101

Closed aldegoeij closed 1 year ago

aldegoeij commented 4 years ago

Issue #, if available: Usage of sed creates issues e.g. when used in pipelines, due to the differences in sed between MacOS and GNU Linux, for details see https://github.com/awslabs/aws-waf-security-automations/issues/100

Description of changes:

moved all usage of sed to perl to have cross-platform compatibility
minor layout updates to documentation strings

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

beomseoklee commented 4 years ago

Thanks for your input. As you said, if you run sed -i '' -e "s/%%BUCKET_NAME%%/$1/g" target.template on Mac, it would create aws-waf-security-automations.template-e file.

We would consider the better way as you mentioned.

aldegoeij commented 4 years ago

@georgebearden why did you not include this PR in version 2.3.1?

aijunpeng commented 1 year ago

Close the old PR as it doesn't apply to the latest version.