Support node v10 - Githubissues

aws-solutions / aws-waf-security-automations

This solution automatically deploys a single web access control list (web ACL) with a set of AWS WAF rules designed to filter common web-based attacks.

https://aws.amazon.com/solutions/aws-waf-security-automations

Apache License 2.0

845 stars 361 forks source link

Support node v10 #106

Closed jgeurts closed 3 years ago

jgeurts commented 4 years ago

Issue #: #99

Description of changes:

Support node v10
Remove async library
Update javascript syntax to leverage async/await and classes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jgeurts commented 4 years ago

Anything needed for this PR?

jgeurts commented 4 years ago

@hvital is there anything I can do to get this merged?

knihit commented 4 years ago

Thank you for the PR. We will review and plan for it in a future release

knihit commented 4 years ago

Hi @jgeurts, the solution has been updated to Node10.x.

jgeurts commented 4 years ago

@knihit the async library really should be removed. It's garbage and swallows exceptions thrown in the callback functions. With node 10+, there's no reason to use the async library anymore

knihit commented 4 years ago

Hi @jgeurts, agree to your comments. We will plan this in the upcoming releases