aws-solutions / aws-waf-security-automations

This solution automatically deploys a single web access control list (web ACL) with a set of AWS WAF rules designed to filter common web-based attacks.
https://aws.amazon.com/solutions/aws-waf-security-automations
Apache License 2.0
837 stars 359 forks source link

Add A RuleGroup to the Global Policy. Useful for FMS cases. #175

Closed pkennedyvt closed 1 year ago

pkennedyvt commented 3 years ago

Issue #, if available:

Description of changes: Added a Rule group for CLOUDFRONT policy, which can be helpful when used in conjunction with FMS.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aijunpeng commented 3 years ago

Thanks for submitting the PR. We added it to our backlog for evaluation in a future release.

pkennedyvt commented 1 year ago

I thought I had santitized everything, that should not be. It’s a dummy account, but still should come out.

--pk

From: Dmitri Perunov @.> Sent: Tuesday, August 9, 2022 3:05 PM To: awslabs/aws-waf-security-automations @.> Cc: Kennedy, PK @.>; Author @.> Subject: Re: [awslabs/aws-waf-security-automations] Add A RuleGroup to the Global Policy. Useful for FMS cases. (#175)

@diimpp commented on this pull request.


In deployment/aws-waf-security-automations-webacl.templatehttps://github.com/awslabs/aws-waf-security-automations/pull/175#discussion_r941708226:

  • WAFSecAutomationsSecurityGroup:

Is it your company data? Should it really be included in PR?

— Reply to this email directly, view it on GitHubhttps://github.com/awslabs/aws-waf-security-automations/pull/175#pullrequestreview-1067249846, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANADU7SYGBHBDQPX5CAFZR3VYKTVVANCNFSM4SAURQUQ. You are receiving this because you authored the thread.Message ID: @.**@.>>

aijunpeng commented 1 year ago

This is not added to roadmap after evaluation. Close the old ticket.