search

aws-solutions / aws-waf-security-automations

This solution automatically deploys a single web access control list (web ACL) with a set of AWS WAF rules designed to filter common web-based attacks.
https://aws.amazon.com/solutions/aws-waf-security-automations
Apache License 2.0
837 stars 359 forks source link

update URLSuffix and CloudWatch URL to support China regions #217

Closed Paul-AWS closed 1 year ago

Paul-AWS commented 2 years ago

Issue #, if available:

Description of changes:

  1. Change "amazonaws.com" to "{AWS::URLSuffix}" in Outputs to make it available in Beijing/Ningxia region (different API Gateway endpoint)
  2. Add if/else conditions in 4 python files to make it available in Beijing/Ningxia region (different CloudWatch URL)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aijunpeng commented 1 year ago

Thanks for the contribution. "{AWS::URLSuffix}" is a good call. We have added this to our backlog and will evaluate it for future releases.

rakshb commented 1 year ago

Since there is a forked version this solution available in China regions, we will not add item 2 in scope. We will change "amazonaws.com" to "{AWS::URLSuffix} in the next release.

aijunpeng commented 1 year ago

This change has been included in v4.0.0.