search

aws-solutions / aws-waf-security-automations

This solution automatically deploys a single web access control list (web ACL) with a set of AWS WAF rules designed to filter common web-based attacks.
https://aws.amazon.com/solutions/aws-waf-security-automations
Apache License 2.0
835 stars 358 forks source link

Make the AppRegistry conditional #254

Closed taniwallach closed 8 months ago

taniwallach commented 8 months ago

Make the AppRegistry conditional, but default to being on,so this solution can be deployed to a region where the AWS Service Catalog AppRegistry is not available.

Issue # 253

Description of changes: Add a condition so that the AppRegistry integration can be left out when AppRegistry is not available (or if the user does not want it).

Using this change a a private deployment of all the resources into S3 I was able to launch the stack in il-central-1 where AppRegistry is not available (at least not at present).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aijunpeng commented 8 months ago

Thanks for the PR. We have added it to our backlog to consider the possibility of making AppRegistry optional in the future.