search

aws-solutions / aws-waf-security-automations

This solution automatically deploys a single web access control list (web ACL) with a set of AWS WAF rules designed to filter common web-based attacks.
https://aws.amazon.com/solutions/aws-waf-security-automations
Apache License 2.0
835 stars 358 forks source link

feat: support China region deployment #258

Open owenCCY opened 7 months ago

owenCCY commented 7 months ago

Issue #, if available: Service Catalogue App Registry and ApiGatewayBadBot on Edge is not supported in CN regions

Description of changes: Deleted Service Catalogue App Registry Added regional ApiGateway Changed FirehoseAthenaStack and WebACLStack s3 location (You might want to create a new s3 bucket in CN regions)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aijunpeng commented 7 months ago

Thank you for submitting the PR! This WAF solution does not support China region, but you can find a separate WAF solution for China region here https://www.amazonaws.cn/en/solutions/amazon-waf-security-automations/

owenCCY commented 7 months ago

Hi, I updated my last commit and make it compatible for both CN and Global regions. (Based on deployment test from my side).

I am from the CSDC team in China. I saw the solution version for global is 4.0.3 now but the China version is still 3.x, which is not updated. So I think, may be this solution can be made compatible for both China and Global regions?

Please let me know your thoughts, thanks! Or, we can have a discussion online.

Best.

aijunpeng commented 7 months ago

Thanks! We are discussing with your team about the path forward on this.