search

aws-solutions / aws-waf-security-automations

This solution automatically deploys a single web access control list (web ACL) with a set of AWS WAF rules designed to filter common web-based attacks.
https://aws.amazon.com/solutions/aws-waf-security-automations
Apache License 2.0
857 stars 364 forks source link

Regional bucket requirement does not allow for multiple regions #269

Closed LewS closed 2 months ago

LewS commented 2 months ago

Per the README Instructions One regional bucket for each AWS Region where you plan to deploy the solution. Use the name of the global bucket as the prefix of the bucket name, and suffix it with the region name. Regional assets such as Lambda code are stored here. For example, mybucket-us-east-1. However when you build the solution using build-s3-dist.sh it only accepts one parameter for DIST_OUTPUT_BUCKET that is required for regional deployment, which is also referenced in the global template under mappings at line 693 SourceBucket: '%DIST_OUTPUT_BUCKET%'. How can this solution be deployed to multiple regions without overwriting the global templates within the TEMPLATE_OUTPUT_BUCKET each time...

LewS commented 2 months ago

I see that the region is appended deeper down. Doco should be updated to include the region in the s3 upload for the regional assets. The zip download does not contain the latest code nor instructions.

kroeter commented 2 months ago

Thank you, we will add for our next release