search

aws-solutions / aws-waf-security-automations

This solution automatically deploys a single web access control list (web ACL) with a set of AWS WAF rules designed to filter common web-based attacks.
https://aws.amazon.com/solutions/aws-waf-security-automations
Apache License 2.0
857 stars 364 forks source link

Inconsistent "aws-waf-security-automations-alb.template" #65

Closed gary-tsai-zocdoc closed 5 years ago

gary-tsai-zocdoc commented 6 years ago

Hi,

After multiple deployments of CloudFormation stack using aws-waf-security-automations-alb.template, i realized there are 2 versions of the template.

Template from docs.aws.amazon.com is different than Github awslabs/aws-waf-security-automations/deployment/.

I jumped to search for WAF template in Github directly discovered the stack fails to build when using Github version.

Please address the differences as this can cause potential confusion.

hvital commented 6 years ago

Thanks gary-tsai-zocdoc,

We're going to check this differences and update the repo when we publish the next version.

In the meantime, please keep using the templates you've commented: https://docs.aws.amazon.com/solutions/latest/aws-waf-security-automations/template.html

hvital commented 5 years ago

Hi @gary-tsai-zocdoc

We've just pushed a new version and updated the solution's doc page. The template should be the same now.

Thanks!