hvital
commented
6 years ago Hi d-j-c,
Thanks for your comment. Based on the previous feedbacks, we're working on an update .. the main focus is to clean up all repo's contributions. This includes:
- https://github.com/awslabs/aws-waf-security-automations/pull/64
- https://github.com/awslabs/aws-waf-security-automations/issues/57
- https://github.com/awslabs/aws-waf-security-automations/issues/62
- https://github.com/awslabs/aws-waf-security-automations/issues/63
- https://github.com/awslabs/aws-waf-security-automations/issues/44
- https://github.com/awslabs/aws-waf-security-automations/issues/60
As for the template complexity, cfn-lint might help to remove implicit dependencies and I'm still considering translate it o YAML.
Please, feel free to open as many issues you consider that it's important to be included ... we will answer them all (and try to address as many as possible in this upcoming version).
Many thanks!
simplycloud
jbabe
It seems to me that this project is not a good choice at all for anybody to use aside from as an example and PoC. There are multiple reasons I say this:
It is a good example of what could be done with AWS WAF, however I have found myself on more than one occasional dealing with clients who believe that this repo is the best choice for them to roll out AWS WAF simply based off AWS blog promoting it. I believe that this is creating a maintenance risk in these organisations, who also end up spending significant time patching in their own changes to this repo instead of starting from a clean slate.
The point of submitting this Issue is to see if AWS will alter their Blog and/or README to clearly state this this is an example only and to recommend that customers use something a bit more fit for purpose based on their actual needs.