dengmingtong commented 4 months ago

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Summary

(describe what this merge request does)

Implementation highlights

(describe how the merge request does for feature changes, share the RFC link if it has)

Test checklist

[ ] add new test cases
[ ] all code changes are covered by unit tests
[ ] end-to-end tests
- [ ] deploy web console with CloudFront + S3 + API gateway
- [ ] deploy web console within VPC
- [ ] deploy ingestion server
- [ ] with MSK sink
- [ ] with KDS sink
- [ ] with S3 sink
- [ ] deploy data processing
- [ ] deploy data modeling
- [ ] new Redshift Serverless
- [ ] provisioned Redshift
- [ ] Athena
- [ ] deploy with reporting
- [ ] streaming ingestion
- [ ] with Redshift Serverless
- [ ] with provisioned Redshift

Is it a breaking change

[ ] add parameters without default value in stack
[ ] introduce new service permission in stack
[ ] introduce new top level stack module

Miscellaneous

[ ] introduce new symbol link source file(s) to be shared among infra code, web console frontend, and web console backend

github-actions[bot] commented 4 months ago

Etl common library's test coverage

Overall Project	93.47%	:green_apple:

There is no coverage information present for the Files changed

github-actions[bot] commented 4 months ago

Package	Line Rate	Branch Rate	Health
src	100%	85%	✔
src.analytics	100%	100%	✔
src.analytics.lambdas	92%	88%	✔
src.analytics.lambdas.clear-expired-events-workflow	100%	100%	✔
src.analytics.lambdas.custom-resource	96%	87%	✔
src.analytics.lambdas.load-data-workflow	99%	90%	✔
src.analytics.lambdas.refresh-materialized-views-workflow	96%	88%	✔
src.analytics.lambdas.scan-metadata-workflow	97%	88%	✔
src.analytics.lambdas.sql-execution-sfn	93%	60%	✔
src.analytics.private	100%	91%	✔
src.analytics.private.athena	100%	100%	✔
src.base-lib.src	100%	100%	✔
src.base-lib.src.auth	89%	65%	✔
src.base-lib.src.common	97%	71%	✔
src.base-lib.src.constant	100%	100%	✔
src.base-lib.src.model	100%	100%	✔
src.common	97%	78%	✔
src.common.lambda	97%	86%	✔
src.control-plane	97%	72%	✔
src.control-plane.auth	93%	12%	✔
src.control-plane.backend	100%	88%	✔
src.control-plane.backend.lambda.api	97%	33%	✔
src.control-plane.backend.lambda.api.common	92%	80%	✔
src.control-plane.backend.lambda.api.middle-ware	89%	82%	✔
src.control-plane.backend.lambda.api.model	96%	55%	✔
src.control-plane.backend.lambda.api.router	99%	100%	✔
src.control-plane.backend.lambda.api.service	85%	68%	✔
src.control-plane.backend.lambda.api.service.quicksight	93%	81%	✔
src.control-plane.backend.lambda.api.store.aws	87%	56%	✔
src.control-plane.backend.lambda.api.store.dynamodb	90%	80%	✔
src.control-plane.backend.lambda.api.test.api	99%	81%	✔
src.control-plane.backend.lambda.batch-insert-ddb	94%	86%	✔
src.control-plane.backend.lambda.listen-stack-status	81%	52%	✔
src.control-plane.backend.lambda.listen-state-status	91%	50%	✔
src.control-plane.backend.lambda.sfn-action	88%	50%	✔
src.control-plane.backend.lambda.sfn-workflow	80%	67%	➖
src.control-plane.backend.layer.lambda-web-adapter	98%	40%	✔
src.control-plane.private	100%	100%	✔
src.data-pipeline	100%	100%	✔
src.data-pipeline.lambda.copy-assets	97%	90%	✔
src.data-pipeline.lambda.emr-job-state-listener	96%	91%	✔
src.data-pipeline.lambda.emr-job-submitter	99%	77%	✔
src.data-pipeline.lambda.emr-serverless-app	96%	86%	✔
src.data-pipeline.lambda.partition-syncer	98%	89%	✔
src.data-pipeline.tables	100%	100%	✔
src.data-pipeline.utils	100%	94%	✔
src.ingestion-server.custom-resource	100%	100%	✔
src.ingestion-server.custom-resource.delete-ecs-cluster	98%	90%	✔
src.ingestion-server.custom-resource.update-alb-rules	100%	78%	✔
src.ingestion-server.kafka-s3-connector	100%	100%	✔
src.ingestion-server.kafka-s3-connector.custom-resource.kafka-s3-sink-connector	96%	82%	✔
src.ingestion-server.kinesis-data-stream	100%	100%	✔
src.ingestion-server.kinesis-data-stream.kinesis-to-s3-lambda	100%	100%	✔
src.ingestion-server.kinesis-data-stream.private	100%	100%	✔
src.ingestion-server.server	98%	89%	✔
src.ingestion-server.server.private	96%	89%	✔
src.metrics	100%	100%	✔
src.metrics.custom-resource.add-sns-subscription	95%	86%	✔
src.metrics.custom-resource.get-interval	99%	97%	✔
src.metrics.custom-resource.put-dashboard	97%	84%	✔
src.metrics.custom-resource.set-metrics-widgets	98%	93%	✔
src.private	97%	72%	✔
src.reporting	100%	80%	✔
src.reporting.lambda.custom-resource.quicksight	94%	81%	✔
src.reporting.private	90%	54%	✔
test	94%	83%	✔
test.common	93%	100%	✔
test.control-plane	97%	64%	✔
test.ingestion-server.server	97%	95%	✔
Summary	96% (69757 / 72768)	74% (6055 / 8131)	✔

Minimum allowed line rate is 60%

github-actions[bot] commented 4 months ago

Data Pipeline spark application's test coverage

Overall Project	98.15%	:green_apple:

There is no coverage information present for the Files changed

aws-solution-clickstream-analytics commented 4 months ago

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @dengmingtong on pull_request

Metric	Status	Value	Error Threshold
Reliability rating	:white_check_mark: OK	1	> 1
Security rating	:white_check_mark: OK	1	> 1
Sqale rating	:white_check_mark: OK	1	> 1
Coverage	:white_check_mark: OK	83.60	< 80
Duplicated lines density	:white_check_mark: OK	5.60	> 30
Blocker violations	:white_check_mark: OK	0	> 0
Bugs	:white_check_mark: OK	0	> 0
Code smells	:white_check_mark: OK	2	> 40
Critical violations	:white_check_mark: OK	0	> 0
Major violations	:white_check_mark: OK	0	> 0
Vulnerabilities	:white_check_mark: OK	0	> 0