aws-solutions / cognito-user-profiles-export-reference-architecture

A reference architecture for exporting user profiles, group details, and group memberships from an Amazon Cognito User Pool to an Amazon DynamoDB global table using AWS Step Functions and AWS Lambda.
https://aws.amazon.com/solutions/implementations/cognito-user-profiles-export-reference-architecture/
Apache License 2.0
52 stars 19 forks source link

Enable deletion protection on BackupTable #42

Open Olesp opened 10 months ago

Olesp commented 10 months ago

Description of changes: This enable the deletion protection on the backup table. This prevent from any accidental deletion. This is considered as a fail when using the cfn-lint command.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mikeols commented 10 months ago

Thank you @Olesp! We will review this change. We cannot merge these PRs directly, but will incorporate it into our next release. This change may have unintended consequences for some users, such as leaving tables around that you aren't expecting to remain after a stack deletion. We may implement this using a parameter that defaults to false, but allows the user to change it upon deploy.