aws-solutions / content-localization-on-aws

Automatically generate multi-language subtitles using AWS AI/ML services. Machine generated subtitles can be edited to improve accuracy and downstream tracks will automatically be regenerated based on the edits. Built on Media Insights Engine (https://github.com/awslabs/aws-media-insights-engine)
Apache License 2.0
41 stars 17 forks source link

Vue Website fails to build #352

Closed giusedroid closed 6 months ago

giusedroid commented 2 years ago

Describe the bug

npm build of ./source/website fails with the following error

$: npm run build

AWS_Content_Localization@0.1.0 build
vue-cli-service build

⠧  Building for production...

 ERROR  Failed to compile with 1 error                                                                                                                                                                                                                

This dependency was not found:

* @/../node_modules/videojs-hotkeys/build/videojs.hotkeys.min.js in ./node_modules/cache-loader/dist/cjs.js??ref--12-0!./node_modules/thread-loader/dist/cjs.js!./node_modules/babel-loader/lib!./node_modules/cache-loader/dist/cjs.js??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./src/components/VideoPlayer.vue?vue&type=script&lang=js&

To install it, you can run: npm install --save @/../node_modules/videojs-hotkeys/build/videojs.hotkeys.min.js
 ERROR  Build failed with errors.

To Reproduce

cd ./source/website
npm i
npm run build

Expected behavior

it actually builds

Please complete the following information about the solution:

Screenshots

If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information).

Additional context

Tested build on Node 16.13.0 on both macOS and Cloud9 AmazonLinux 2.0

giusedroid commented 2 years ago

raised a PR. Can you please review it? https://github.com/aws-solutions/content-localization-on-aws/pull/353

cassneal commented 2 years ago

We will discuss this ticket and now PR in our next backlog review meeting.

cassneal commented 2 years ago

Thanks for the PR. We reviewed this ticket and have added a task for the PR review and potential merge into the backlog for the next update we do this for solution. Date TBD.

raulmlamzn commented 6 months ago

Closing this issue since solution was upgraded to Vue.js v3 in 2.1.3: https://github.com/aws-solutions/content-localization-on-aws/releases