search

aws-solutions / media-services-application-mapper

Media Services Application Mapper is a browser-based tool that allows operators to visualize the structure and logical connections among AWS Media Services and supporting services in the cloud. The tool can be used as a top-down resource monitoring tool when integrated with CloudWatch.
Apache License 2.0
84 stars 27 forks source link

Handle paginated results from describe_alarms call #181

Closed morjoan closed 3 years ago

morjoan commented 3 years ago

Running Amazon CodeGuru's repo analysis on MSAM turned up with this finding:

cloudwatch.py Line: 71 The API method describe_alarms returns paginated results instead of all results. Consider using the pagination API or checking one of the following keys in the response to verify that all results were returned: IsTruncated, NextToken.

morjoan commented 3 years ago

This call to describe_alarms takes a list of alarms but only one alarm is ever passed and will never return paginated results. Won't fix.