aws-solutions / media-services-application-mapper

Media Services Application Mapper is a browser-based tool that allows operators to visualize the structure and logical connections among AWS Media Services and supporting services in the cloud. The tool can be used as a top-down resource monitoring tool when integrated with CloudWatch.
Apache License 2.0
83 stars 34 forks source link

S3 bucket to MediaLive connection mapper missing s3:// URLs #227

Closed JimTharioAmazon closed 2 years ago

JimTharioAmazon commented 3 years ago

We have a match pattern for s3:// URLs, but it appears to be missing the match due to constraints in the pattern and method used in the Python re module.

This isn't matching: s3://media-sources-eu-west-3/waves.mp4

Here is the specific mapper: https://github.com/awslabs/aws-media-services-application-mapper/blob/master/source/msam/chalicelib/connections.py#L492

morjoan commented 2 years ago

@JimTharioAmazon i just tried this out on your sample source URL in the python command line using one of our defined expressions re.compile(r"s3\:\/\/([^\/]+)") and I'm getting a match. What we don't match is something like "s3ssl://.." which is a valid URL. We'll need to accommodate for that.