aws-solutions / network-orchestration-for-aws-transit-gateway

The Network Orchestration for AWS Transit Gateway solution automates the process of setting up and managing transit networks in distributed AWS environments. It creates a web interface to help control, audit, and approve (transit) network changes.
https://aws.amazon.com/solutions/implementations/serverless-transit-network-orchestrator/
Apache License 2.0
113 stars 48 forks source link

can only join an iterable #121

Open Cupidazul opened 1 month ago

Cupidazul commented 1 month ago

When VPC tag is only half tagged we get and STNO bug. Expected tags: "Propagate-to"" and "Associate-with". Customers that provided only the "Associate-with" will face issues, since there will be no Approvals records shown in StnoWebApp, but StnoStatus tags say that Approval is required. Workaround: Change tgw tags ApprovalRequired=No to disable Approvals.

Symptom: Approvals stop working.for the VPC.

Erro Log:

CloudWatch > Log groups > STNO-Hub-Failures

https://eu-central-1.console.aws.amazon.com/cloudwatch/home?region=eu-central-1#logsV2:log-groups/log-group/STNO-Hub-Failures/log-events/20c.... "error-info": { "Error": "TypeError", "Cause": "{\"errorMessage\":\"can only join an iterable\",\"errorType\":\"TypeError\",\"requestId\":\"8e3d....d7\",\"stackTrace\":[\" File \\"/var/task/state_machine/index.py\\", line 196, in lambda_handler\n return sns(event, function_name)\n\",\" File \\"/var/task/state_machine/index.py\\", line 147, in sns\n response = sns.notify()\n\",\" File \\"/var/task/state_machine/state_machine_handler.py\\", line 2437, in notify\n self._send_email()\n\",\" File \\"/var/task/state_machine/state_machine_handler.py\\", line 2502, in _send_email\n \\", \\".join(self.event.get(\\"Propagate-to\\")).title(),\n\"]}" }, "Comment": "can only join an iterable"

gsingh04 commented 1 month ago

Thank you for raising the issue. The solution requires both Propagate-to and Associate-with tags on the vpc. For better resolution of the issue can you confirm following:

Steps to replicate the issue (please add missing steps):

Expected behavior: Please provide details on the expected behavior after the fix

Cupidazul commented 1 month ago

The tenant was using Terraform and not awscf.

Do note that our symptom was that, after the first half tagging, we entered into a state that, even if we had both tags,.stno web app didnt receive Approvals anymore, but we had many events with both tags.

Sorry to inform, that, as of now, I dont have more info nor am I able to apply a fix.

Just thought I could share this strange behaviour into the project.