search

aws-solutions / network-orchestration-for-aws-transit-gateway

The Network Orchestration for AWS Transit Gateway solution automates the process of setting up and managing transit networks in distributed AWS environments. It creates a web interface to help control, audit, and approve (transit) network changes.
https://aws.amazon.com/solutions/implementations/serverless-transit-network-orchestrator/
Apache License 2.0
113 stars 48 forks source link

Deploy service linked role stack as part of the spoke stack #123

Open cheng514 opened 1 month ago

cheng514 commented 1 month ago

Is your feature request related to a problem? Please describe. The service-linked-roke spoke stack is marked as optional, but it is required (without manually doing the attachment first) for existing/new AWS accounts that never had attachments before to work with the tag automation.

We can't simply deploy the service-linked-role stack using stacksets as some accounts will already have this role and return error. This makes it harder to automate the service-linked-role creation for member accounts.

Describe the feature you'd like

I'd like the spoke template to perform a check on whether the service linked role already exist, and if not, create it as part of the same stack. This way users won't need to worry about the service linked role to avoid troubleshooting efforts.

Additional context I can help with the solution for this if the team wants to implement this. Thanks.

gsingh04 commented 3 weeks ago

Thank you @cheng514 for the query. The feature ask makes sense. If you are willing to collaborate, we would love to have a PR for it.

cheng514 commented 3 weeks ago

Thanks @gsingh04, more than happy to. Please feel free to assign this issue to me, i'll submit a PR for review when its ready.

cheng514 commented 2 weeks ago

Hi @gsingh04 , i have opened PR for this issue - https://github.com/aws-solutions/network-orchestration-for-aws-transit-gateway/pull/128

Please let me know if there are any issues. Thanks!